Codecov Report

Merging #218 (ef2bfdc) into master (f6b07f8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #218   +/-   ##
=========================================
  Coverage     59.13%   59.13%           
  Complexity     1327     1327           
=========================================
  Files           160      160           
  Lines          8727     8727           
  Branches        817      817           
=========================================
  Hits           5161     5161           
  Misses         3301     3301           
  Partials        265      265           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok?

PTAL @jerqi

I can't get the point. Could you give me more explanation?

Now the require-memory retry threshold time > 60s in shuffle-server and the client grpc request max-time is 60s, it means that when the shuffle -shuffle memory is tight and the request time reached the 60s, the client side only will show the request timeout exception instead of requiring memory failed log.

Now the require-memory retry threshold time > 60s in shuffle-server and the client grpc request max-time is 60s, it means that when the shuffle -shuffle memory is tight and the request time reached the 60s, the client side only will show the request timeout exception instead of requiring memory failed log.

OK, make sense, Let's merge it, thanks @zuston